Skip to content

chore: remove unused imports in dashboard middleware#8599

Closed
Olexandr88 wants to merge 1 commit intothirdweb-dev:mainfrom
Olexandr88:main
Closed

chore: remove unused imports in dashboard middleware#8599
Olexandr88 wants to merge 1 commit intothirdweb-dev:mainfrom
Olexandr88:main

Conversation

@Olexandr88
Copy link
Contributor

@Olexandr88 Olexandr88 commented Jan 1, 2026 •
edited
Loading

No description provided.

@Olexandr88 Olexandr88 requested review from a team as code owners January 1, 2026 12:07
@changeset-bot
Copy link

changeset-bot bot commented Jan 1, 2026

⚠️ No Changeset found

Latest commit: cdd555c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 1, 2026

@Olexandr88 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 1, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 1, 2026 •
edited
Loading

Walkthrough

Two unused imports were removed from the middleware module: getChainMetadata from the thirdweb/chains package and isValidENSName from the thirdweb/utils package. No functional logic changes are present.

Changes

Cohort / File(s) Summary
Unused import removal
apps/dashboard/src/middleware.ts		 Removed two unused imports: getChainMetadata from "thirdweb/chains" and isValidENSName from "thirdweb/utils"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description provided by the author, violating the repository's template requirements. Add a pull request description following the template format, including title format [SDK/Dashboard/Portal] Feature/Fix, reviewer notes, and testing instructions.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing unused imports from the dashboard middleware file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added Stale and removed Stale labels Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 25, 2026
@github-actions github-actions bot closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Olexandr88